Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8670

MavenBuild does not respect the "alternate settings" value of its parent MavenModuleSetBuild

    Details

    • Similar Issues:

      Description

      So the logic used to prepare the arguments for executing Maven are very similar between MavenBuild and MavenModuleSetBuild. I'm unsure why they don't share a common source? There's one glaring difference for me that is causing trouble and that's lack of support for the "alternate settings" attribute when running a MavenBuild directly (by going into the Modules of a Maven build and running a module directly.)

      From MavenModuleSetBuild
                              if (project.getAlternateSettings() != null) {
                                  if (IOUtils.isAbsolute(project.getAlternateSettings())) {
                                      margs.add("-s").add(project.getAlternateSettings());
                                  } else {
                                      FilePath mrSettings = getModuleRoot().child(project.getAlternateSettings());
                                      FilePath wsSettings = getWorkspace().child(project.getAlternateSettings());
                                      if (!wsSettings.exists() && mrSettings.exists())
                                          wsSettings = mrSettings;
                                      
                                      margs.add("-s").add(wsSettings.getRemote());
                                  }
                              }
      

      I'm putting a patch together for this on Github and will update the issue when it's complete.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          http://jenkins-ci.org/commit/core/f6bd1f306d9b8bf20ff78fb84ae19a07b3fb5c12
          Log:
          [FIXED JENKINS-8670] recording the fix

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html http://jenkins-ci.org/commit/core/f6bd1f306d9b8bf20ff78fb84ae19a07b3fb5c12 Log: [FIXED JENKINS-8670] recording the fix
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          maven-plugin/src/main/java/hudson/maven/MavenBuild.java
          http://jenkins-ci.org/commit/core/fa9c55884194def3a034115f4b875050dfaf6f2f
          Log:
          Merge branch 'JENKINS-8670'

          • JENKINS-8670:
            [FIXED JENKINS-8670] recording the fix
            Added support to MavenBuild for alternateSettings
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html maven-plugin/src/main/java/hudson/maven/MavenBuild.java http://jenkins-ci.org/commit/core/fa9c55884194def3a034115f4b875050dfaf6f2f Log: Merge branch ' JENKINS-8670 ' JENKINS-8670 : [FIXED JENKINS-8670] recording the fix Added support to MavenBuild for alternateSettings
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kphonik
          Path:
          src/main/java/hudson/maven/MavenBuild.java
          http://jenkins-ci.org/commit/maven-plugin/80a1b237122e85eb8978b8f2d94558812805c2cc
          Log:
          Added support to MavenBuild for alternateSettings

          JENKINS-8670

          Originally-Committed-As: ec9dce7dbae9ca7b2bf72d66413109084cd8c863

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kphonik Path: src/main/java/hudson/maven/MavenBuild.java http://jenkins-ci.org/commit/maven-plugin/80a1b237122e85eb8978b8f2d94558812805c2cc Log: Added support to MavenBuild for alternateSettings JENKINS-8670 Originally-Committed-As: ec9dce7dbae9ca7b2bf72d66413109084cd8c863

            People

            • Assignee:
              kphonik Jason Stiefel
              Reporter:
              kphonik Jason Stiefel
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: