Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-8916

Allowing same type of parameter for triggered build more than once seems redundant

    Details

      Description

      While working on JENKINS-7377 I noticed that it's redundant and confusing to allow the same type of parameter for a triggered build more than once.
      For example, right now it's possible to specify "Current Build Parameters", or "Subversion Revision" two or more times.
      The only type where it might make sense is "Parameters from properties file".

      I think for every type of parameters a simple checkbox is sufficient.

      I'll try to make the necessary changes and open a pull request, but appreciate comments or criticism.

        Issue Links

          Activity

          Hide
          fredg Fred G added a comment -

          I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly:

          <f:hetero-list name="configs" hasHeader="true"
                         descriptors="${descriptor.getBuilderConfigDescriptors()}"
                         items="${instance.configs}"
                         addCaption="${%Add Parameters}"
          />
          

          with something like

          <f:descriptorList descriptors="${descriptor.getBuilderConfigDescriptors()}" instances="${instance.configs}"/>
          

          It looks ok, but unfortunately does not save which type of parameter was selected (checked).

          Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.)

          Best Regards,

          Fred

          Show
          fredg Fred G added a comment - I'm trying to replace the following jelly script in BuildTriggerConfig/config.jelly: <f:hetero-list name= "configs" hasHeader= " true " descriptors= "${descriptor.getBuilderConfigDescriptors()}" items= "${instance.configs}" addCaption= "${%Add Parameters}" /> with something like <f:descriptorList descriptors= "${descriptor.getBuilderConfigDescriptors()}" instances= "${instance.configs}" /> It looks ok, but unfortunately does not save which type of parameter was selected (checked). Could you give me hint what I need to do to get it working? Is there any other jelly tag that deals with a list and displays checkboxes? (I noticed that <f:hetero-radio/> exists, but unfortunately it allows only radio buttons.) Best Regards, Fred
          Show
          fredg Fred G added a comment - Pull request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/20
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Fred G
          Path:
          src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
          src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc
          Log:
          [FIXED JENKINS-8916] Allowing same type of parameter for triggered build
          more than once seems redundant

          It requires Jenkins core version 1.463 to work, but it's fully
          backwards compatible.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/3f6097a82679a76d8b0b03498d9c9a392b77f6fc Log: [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant It requires Jenkins core version 1.463 to work, but it's fully backwards compatible.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Fred G
          Path:
          src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly
          src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0
          Log:
          Merge pull request #20 from fredg02/master

          [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant

          Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Fred G Path: src/main/resources/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig/config.jelly src/main/resources/hudson/plugins/parameterizedtrigger/BuildTriggerConfig/config.jelly http://jenkins-ci.org/commit/parameterized-trigger-plugin/6e80ae37591b708b321b27a80a8d32012949f6a0 Log: Merge pull request #20 from fredg02/master [FIXED JENKINS-8916] Allowing same type of parameter for triggered build more than once seems redundant Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/76d4c9b...6e80ae3
          Hide
          danielbeck Daniel Beck added a comment -

          All parameter sources are only supported once now, i.e. it's not possible to specify multiple property files anymore?

          Show
          danielbeck Daniel Beck added a comment - All parameter sources are only supported once now, i.e. it's not possible to specify multiple property files anymore?
          Hide
          fredg Fred G added a comment -

          Yes, that's the only drawback with this solution. Do you have a use-case where you need to specify multiple property files?

          Show
          fredg Fred G added a comment - Yes, that's the only drawback with this solution. Do you have a use-case where you need to specify multiple property files?
          Hide
          cockers_97 Andrew Cockerill added a comment -

          Hi. I have several Jobs that use multiple 'parameters from properties file' parameters. I would really like to see this functionality put back in.

          Show
          cockers_97 Andrew Cockerill added a comment - Hi. I have several Jobs that use multiple 'parameters from properties file' parameters. I would really like to see this functionality put back in.
          Hide
          jlpinardon jlpinardon added a comment -

          Dear all,

          I support several teams for which it is really annoying to not be able to add several property files.
          So please could you either :

          • let the possibility to add several times property file type
          • or have a single property file type but allow to give a comma separated list of files.
          Show
          jlpinardon jlpinardon added a comment - Dear all, I support several teams for which it is really annoying to not be able to add several property files. So please could you either : let the possibility to add several times property file type or have a single property file type but allow to give a comma separated list of files.
          Hide
          fredg Fred G added a comment -

          @jlpinardon
          This has already been fixed (see JENKINS-15834) and it's available in version 2.17 of the Parameterized Trigger Build Plugin.
          You can specify a comma separated list of property files now.

          Show
          fredg Fred G added a comment - @jlpinardon This has already been fixed (see JENKINS-15834 ) and it's available in version 2.17 of the Parameterized Trigger Build Plugin. You can specify a comma separated list of property files now.

            People

            • Assignee:
              danielbeck Daniel Beck
              Reporter:
              fredg Fred G
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: