Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9309

sloccount trend report only works up to last failed build

    Details

    • Similar Issues:

      Description

      The rend report generated by the sloccount plugin is destroyed by failing builds. The trend report only displays the results up to the last failing build. This reduces the usefulness of the report as no general view over the whole project life time is possible.

        Attachments

          Activity

          Hide
          pencil Nils Caspar added a comment -

          True story... It's very annoying.

          Show
          pencil Nils Caspar added a comment - True story... It's very annoying.
          Hide
          sogabe sogabe added a comment -

          @kbrandt

          I tried your pull request.
          It seemed OK but clicking a failed build cause exception.
          See attached log and screenshot.

          Show
          sogabe sogabe added a comment - @kbrandt I tried your pull request. It seemed OK but clicking a failed build cause exception. See attached log and screenshot.
          Hide
          ben25 Karsten Brandt added a comment - - edited

          @sogabe:Hello Seiji!

          Ups, this use case was not tested by me.
          I have changed the behaviour of the perform function again.
          For more details look into my new commits:

          https://github.com/kbrandt/sloccount-plugin/commit/92f5ca9855f4bbf65f95c61b4ab9ca1e606c6f37
          https://github.com/kbrandt/sloccount-plugin/commit/2d0f2d6358cad6ae144abef5e6f304c4e3e5bb94

          Please, try again!

          Many thanks in advance,
          Karsten

          Show
          ben25 Karsten Brandt added a comment - - edited @sogabe:Hello Seiji! Ups, this use case was not tested by me. I have changed the behaviour of the perform function again. For more details look into my new commits: https://github.com/kbrandt/sloccount-plugin/commit/92f5ca9855f4bbf65f95c61b4ab9ca1e606c6f37 https://github.com/kbrandt/sloccount-plugin/commit/2d0f2d6358cad6ae144abef5e6f304c4e3e5bb94 Please, try again! Many thanks in advance, Karsten
          Hide
          sogabe sogabe added a comment -

          @kbrandt
          It looks good!
          I'll merge and release in a short time.

          Show
          sogabe sogabe added a comment - @kbrandt It looks good! I'll merge and release in a short time.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Karsten Brandt
          Path:
          src/main/java/hudson/plugins/sloccount/SloccountProjectAction.java
          src/main/java/hudson/plugins/sloccount/SloccountPublisher.java
          http://jenkins-ci.org/commit/sloccount-plugin/ba86876f210ffc7e210d740fd938cef7b9cf04d3
          Log:
          [FIXED JENKINS-9309]

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Karsten Brandt Path: src/main/java/hudson/plugins/sloccount/SloccountProjectAction.java src/main/java/hudson/plugins/sloccount/SloccountPublisher.java http://jenkins-ci.org/commit/sloccount-plugin/ba86876f210ffc7e210d740fd938cef7b9cf04d3 Log: [FIXED JENKINS-9309]
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Karsten Brandt
          Path:
          src/main/java/hudson/plugins/sloccount/ReportSummary.java
          src/main/java/hudson/plugins/sloccount/SloccountBuildAction.java
          src/main/java/hudson/plugins/sloccount/SloccountProjectAction.java
          src/main/java/hudson/plugins/sloccount/SloccountPublisher.java
          http://jenkins-ci.org/commit/sloccount-plugin/92f5ca9855f4bbf65f95c61b4ab9ca1e606c6f37
          Log:
          [FIXED JENKINS-9309] sloccount trend report only works up to last failed build (second version)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Karsten Brandt Path: src/main/java/hudson/plugins/sloccount/ReportSummary.java src/main/java/hudson/plugins/sloccount/SloccountBuildAction.java src/main/java/hudson/plugins/sloccount/SloccountProjectAction.java src/main/java/hudson/plugins/sloccount/SloccountPublisher.java http://jenkins-ci.org/commit/sloccount-plugin/92f5ca9855f4bbf65f95c61b4ab9ca1e606c6f37 Log: [FIXED JENKINS-9309] sloccount trend report only works up to last failed build (second version)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Karsten Brandt
          Path:
          src/main/java/hudson/plugins/sloccount/SloccountPublisher.java
          src/main/java/hudson/plugins/sloccount/model/SloccountParser.java
          http://jenkins-ci.org/commit/sloccount-plugin/2d0f2d6358cad6ae144abef5e6f304c4e3e5bb94
          Log:
          [FIXED JENKINS-9309] sloccount trend report only works up to last failed build (3th version)

          Compare: https://github.com/jenkinsci/sloccount-plugin/compare/2a42be3148e1...2d0f2d6358ca

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Karsten Brandt Path: src/main/java/hudson/plugins/sloccount/SloccountPublisher.java src/main/java/hudson/plugins/sloccount/model/SloccountParser.java http://jenkins-ci.org/commit/sloccount-plugin/2d0f2d6358cad6ae144abef5e6f304c4e3e5bb94 Log: [FIXED JENKINS-9309] sloccount trend report only works up to last failed build (3th version) Compare: https://github.com/jenkinsci/sloccount-plugin/compare/2a42be3148e1...2d0f2d6358ca
          Hide
          mixalturek Michal Turek added a comment -

          Closing old non-closed but resolved tasks. Fixed in version 1.8 according to wiki, this type of issue fixed in version 1.11 too.

          Show
          mixalturek Michal Turek added a comment - Closing old non-closed but resolved tasks. Fixed in version 1.8 according to wiki, this type of issue fixed in version 1.11 too.

            People

            • Assignee:
              ben25 Karsten Brandt
              Reporter:
              languitar Johannes Wienke
            • Votes:
              5 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: