Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16437

Extract MailAddressResolvers to dedicated plugins

    Details

    • Similar Issues:

      Description

      Extract resolvers into separate plugins to allow administrator to decide which resolvers to use.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            I have to agree with @kutzi that having published plugins known to cause abysmal performance problems is not a good idea. Lots of people will just blindly install stuff and not read the warnings. Better to unconditionally delete bad code.

            If there is a real use case for mail address resolvers that infer information from build records, then they should be written carefully to have reasonable performance. For example:

            • require the user to specify a sample job or jobs, rather than searching every job in the Jenkins installation
            • inspect only up to some maximum number of build records per job (with lazy loading this is especially critical)
            • cache information obtained from such searches, e.g. using the Database plugin, so you have only a one-time hit
            Show
            jglick Jesse Glick added a comment - I have to agree with @kutzi that having published plugins known to cause abysmal performance problems is not a good idea. Lots of people will just blindly install stuff and not read the warnings. Better to unconditionally delete bad code. If there is a real use case for mail address resolvers that infer information from build records, then they should be written carefully to have reasonable performance. For example: require the user to specify a sample job or jobs, rather than searching every job in the Jenkins installation inspect only up to some maximum number of build records per job (with lazy loading this is especially critical) cache information obtained from such searches, e.g. using the Database plugin, so you have only a one-time hit
            Hide
            olivergondza Oliver Gondža added a comment -
            Show
            olivergondza Oliver Gondža added a comment - Well, lets try to delete it. https://github.com/jenkinsci/mailer-plugin/pull/6
            Hide
            jglick Jesse Glick added a comment -

            For the record, my proposal was to delete the known plugins implementing MailAddressResolver poorly, not to delete the extension point itself which is not inherently harmful.

            Show
            jglick Jesse Glick added a comment - For the record, my proposal was to delete the known plugins implementing MailAddressResolver poorly, not to delete the extension point itself which is not inherently harmful.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/tasks/MailAddressResolver.java
            http://jenkins-ci.org/commit/mailer-plugin/d97647e6bc5fffaafffe9621c8ffbd5d13877b2b
            Log:
            Merge pull request #5 from jenkinsci/wiki_link

            JENKINS-16437 Link to mail address resolution wiki page

            Compare: https://github.com/jenkinsci/mailer-plugin/compare/78a9e893e0b0...d97647e6bc5f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/tasks/MailAddressResolver.java http://jenkins-ci.org/commit/mailer-plugin/d97647e6bc5fffaafffe9621c8ffbd5d13877b2b Log: Merge pull request #5 from jenkinsci/wiki_link JENKINS-16437 Link to mail address resolution wiki page Compare: https://github.com/jenkinsci/mailer-plugin/compare/78a9e893e0b0...d97647e6bc5f
            Hide
            kutzi kutzi added a comment -

            Setting to fixed since this has been done for the CVS and the SVN plugin

            Show
            kutzi kutzi added a comment - Setting to fixed since this has been done for the CVS and the SVN plugin

              People

              • Assignee:
                Unassigned
                Reporter:
                olivergondza Oliver Gondža
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: