Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18723

Relative links to job are built very slowly

    Details

    • Similar Issues:

      Description

      If a View contains 10 jobs, while building relative links Jenkins would build this view 10 times iterating over all Jenkins jobs. This is an extremely inefficient way of building links.

      Details:

      • projectView.jelly#L84 this one asks Functions to build a relative link.
      • Functions.java#L1008 it obtains all items of the view which builds it and accesses Security to iterate through all the jobs in Jenkins. Note, that this code was added 2 months ago.

      Either there should be a different way of building relative path or a different way for building view items.

        Attachments

          Issue Links

            Activity

            Hide
            ctapobep Stanislav Bashkyrtsev added a comment -

            Pull request was sent with the fix: https://github.com/jenkinsci/jenkins/pull/925

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - Pull request was sent with the fix: https://github.com/jenkinsci/jenkins/pull/925
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ctapobep
            Path:
            core/src/main/resources/lib/hudson/projectView.jelly
            http://jenkins-ci.org/commit/jenkins/cc259504ae050e705a55613fbc78e38f81b18496
            Log:
            JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ctapobep Path: core/src/main/resources/lib/hudson/projectView.jelly http://jenkins-ci.org/commit/jenkins/cc259504ae050e705a55613fbc78e38f81b18496 Log: JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/resources/lib/hudson/projectView.jelly
            http://jenkins-ci.org/commit/jenkins/c63e1f7084abc5c1e440d7a1785f2a2d5a035b78
            Log:
            Merge pull request #925 from ctapobep/master

            JENKINS-18723 Fixed performance bottleneck. Corrected the formation of...

            Compare: https://github.com/jenkinsci/jenkins/compare/574fe1409ec8...c63e1f7084ab

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/resources/lib/hudson/projectView.jelly http://jenkins-ci.org/commit/jenkins/c63e1f7084abc5c1e440d7a1785f2a2d5a035b78 Log: Merge pull request #925 from ctapobep/master JENKINS-18723 Fixed performance bottleneck. Corrected the formation of... Compare: https://github.com/jenkinsci/jenkins/compare/574fe1409ec8...c63e1f7084ab
            Hide
            jglick Jesse Glick added a comment -

            Still open, #925 halved the time required but it is still too long.

            Show
            jglick Jesse Glick added a comment - Still open, #925 halved the time required but it is still too long.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2846
            JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var. (Revision cc259504ae050e705a55613fbc78e38f81b18496)

            Result = SUCCESS
            sbashkyrtsev : cc259504ae050e705a55613fbc78e38f81b18496
            Files :

            • core/src/main/resources/lib/hudson/projectView.jelly
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2846 JENKINS-18723 Fixing performance bottleneck, first step. There were 2 times relative path for the job was asked which was replaced by a single time and saving the result in a var. (Revision cc259504ae050e705a55613fbc78e38f81b18496) Result = SUCCESS sbashkyrtsev : cc259504ae050e705a55613fbc78e38f81b18496 Files : core/src/main/resources/lib/hudson/projectView.jelly
            Hide
            ctapobep Stanislav Bashkyrtsev added a comment -

            Let's put it as close at the moment at least with current fixes. If more performance fixes are going to be implemented, new JIRAs will be used for them.

            Show
            ctapobep Stanislav Bashkyrtsev added a comment - Let's put it as close at the moment at least with current fixes. If more performance fixes are going to be implemented, new JIRAs will be used for them.

              People

              • Assignee:
                Unassigned
                Reporter:
                ctapobep Stanislav Bashkyrtsev
              • Votes:
                6 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: