Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23041

Slave systemInfo page breaks when slave is offline

    Details

    • Similar Issues:

      Description

      /computer/foo/systemInfo breaks when slave is offline, as the assumption of the class loader statistics system info is that there is a slave.

      • Remove the link to System Info when slave is offline, no reason to show it.
      • Make the page itself more robust when slave is offline to not show a thread dump.

        Attachments

          Issue Links

            Activity

            Show
            danielbeck Daniel Beck added a comment - https://github.com/jenkinsci/jenkins/pull/1240
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
            http://jenkins-ci.org/commit/jenkins/19a8a5a0e4dea0edba59770e4f63c62f3d1fd070
            Log:
            [FIX JENKINS-23041] Fix systemInfo for offline slaves

            • Don't show link in sidebar
            • Make systemInfo page more robust when accessed via URL
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly http://jenkins-ci.org/commit/jenkins/19a8a5a0e4dea0edba59770e4f63c62f3d1fd070 Log: [FIX JENKINS-23041] Fix systemInfo for offline slaves Don't show link in sidebar Make systemInfo page more robust when accessed via URL
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
            http://jenkins-ci.org/commit/jenkins/e8b1a500c9b9bbccb792c902c914efcb31ca10c9
            Log:
            Merge pull request #1240 from daniel-beck/JENKINS-23041

            [FIX JENKINS-23041] Fix systemInfo for offline slaves

            Compare: https://github.com/jenkinsci/jenkins/compare/551c968c4690...e8b1a500c9b9

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly http://jenkins-ci.org/commit/jenkins/e8b1a500c9b9bbccb792c902c914efcb31ca10c9 Log: Merge pull request #1240 from daniel-beck/ JENKINS-23041 [FIX JENKINS-23041] Fix systemInfo for offline slaves Compare: https://github.com/jenkinsci/jenkins/compare/551c968c4690...e8b1a500c9b9
            Hide
            danielbeck Daniel Beck added a comment -

            Merged towards 1.575.

            Show
            danielbeck Daniel Beck added a comment - Merged towards 1.575.
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3550
            [FIX JENKINS-23041] Fix systemInfo for offline slaves (Revision 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070)

            Result = SUCCESS
            daniel-beck : 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070
            Files :

            • core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
            • core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3550 [FIX JENKINS-23041] Fix systemInfo for offline slaves (Revision 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070) Result = SUCCESS daniel-beck : 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070 Files : core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly
            core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly
            http://jenkins-ci.org/commit/jenkins/93f45a774b7d54e793c5fc22657c3bb025200dad
            Log:
            [FIX JENKINS-23041] Fix systemInfo for offline slaves

            • Don't show link in sidebar
            • Make systemInfo page more robust when accessed via URL

            (cherry picked from commit 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: core/src/main/resources/hudson/slaves/SlaveComputer/sidepanel2.jelly core/src/main/resources/hudson/slaves/SlaveComputer/systemInfo.jelly http://jenkins-ci.org/commit/jenkins/93f45a774b7d54e793c5fc22657c3bb025200dad Log: [FIX JENKINS-23041] Fix systemInfo for offline slaves Don't show link in sidebar Make systemInfo page more robust when accessed via URL (cherry picked from commit 19a8a5a0e4dea0edba59770e4f63c62f3d1fd070)

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                danielbeck Daniel Beck
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: