Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26751

NPE when /script used on offline slave

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      hudson.util.RemotingDiagnostics.executeGroovy does not check for null channel:

      java.lang.NullPointerException
      	at hudson.util.RemotingDiagnostics.executeGroovy(RemotingDiagnostics.java:119)
      	at jenkins.model.Jenkins._doScript(Jenkins.java:3386)
      	at hudson.model.Computer._doScript(Computer.java:1172)
      	at hudson.model.Computer.doScript(Computer.java:1161)
      	at sun.reflect.GeneratedMethodAccessor7323.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:597)
      	at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:298)
      	at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:161)
      	at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:96)
      	at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:120)
      	at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
      	at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:728)
      	... 53 more
      

        Attachments

          Issue Links

            Activity

            Show
            olivergondza Oliver Gondža added a comment - https://github.com/jenkinsci/jenkins/pull/1639
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/util/RemotingDiagnostics.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            core/src/main/resources/lib/hudson/scriptConsole.jelly
            test/src/test/java/jenkins/model/JenkinsTest.java
            http://jenkins-ci.org/commit/jenkins/d8b1111cea8b43ae946788ce9385ac7d1264d738
            Log:
            [FIXED JENKINS-26751] Do not run /script on offline slave

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/util/RemotingDiagnostics.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/sidepanel.jelly core/src/main/resources/lib/hudson/scriptConsole.jelly test/src/test/java/jenkins/model/JenkinsTest.java http://jenkins-ci.org/commit/jenkins/d8b1111cea8b43ae946788ce9385ac7d1264d738 Log: [FIXED JENKINS-26751] Do not run /script on offline slave
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/java/hudson/util/RemotingDiagnostics.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/model/Computer/sidepanel.jelly
            core/src/main/resources/lib/hudson/scriptConsole.jelly
            test/src/test/java/jenkins/model/JenkinsTest.java
            http://jenkins-ci.org/commit/jenkins/8dc70fd69f7aff2e9dcda8dae4578009de714554
            Log:
            Merge pull request #1639 from olivergondza/JENKINS-26751

            [FIXED JENKINS-26751] Do not run /script on offline slave

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/java/hudson/util/RemotingDiagnostics.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/Computer/sidepanel.jelly core/src/main/resources/lib/hudson/scriptConsole.jelly test/src/test/java/jenkins/model/JenkinsTest.java http://jenkins-ci.org/commit/jenkins/8dc70fd69f7aff2e9dcda8dae4578009de714554 Log: Merge pull request #1639 from olivergondza/ JENKINS-26751 [FIXED JENKINS-26751] Do not run /script on offline slave
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4065

            Result = SUCCESS

            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4065 Result = SUCCESS

              People

              • Assignee:
                olivergondza Oliver Gondža
                Reporter:
                olivergondza Oliver Gondža
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: