Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: pipeline
    • Labels:
    • Similar Issues:

      Description

      This may be something that I've missed but how are you planing on adding support to add build wrappers to the Workflow plugin. We depend a lot on a few plugins to modify the console output to for example color code, find match patterns and to filter out password.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild) where Environment is considered Serializable, and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc.

            The tool-env plugin does not need this, due to the standard tool step.

            Show
            jglick Jesse Glick added a comment - Build wrappers could perhaps be integrated by defining a SimpleBuildWrapper API (analogous to SimpleBuildStep and so taking Run and FilePath rather than AbstractBuild ) where Environment is considered Serializable , and introducing a generic Step to run these. This could make it easier to use xvnc-plugin etc. The tool-env plugin does not need this, due to the standard tool step.
            Hide
            jglick Jesse Glick added a comment -

            Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development.

            Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.

            Show
            jglick Jesse Glick added a comment - Went ahead and wrote a custom Step for the Credentials Binding plugin, though it could perhaps have been written using the API under development. Not currently attempting to handling wrappers which decorate the console, as I do not see any straightforward way to support this transparently. If you have some specific plugins in mind, please list the most important ones so I can study what they do and whether that can possibly make sense from within a workflow.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            COMPATIBILITY.md
            http://jenkins-ci.org/commit/workflow-plugin/f3f8cc06f50be32ae54783c959ea916f803dfa83
            Log:
            Updates related to JENKINS-24673

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: COMPATIBILITY.md http://jenkins-ci.org/commit/workflow-plugin/f3f8cc06f50be32ae54783c959ea916f803dfa83 Log: Updates related to JENKINS-24673
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/jenkins/tasks/SimpleBuildWrapper.java
            test/src/test/java/jenkins/tasks/SimpleBuildWrapperTest.java
            http://jenkins-ci.org/commit/jenkins/416bdef94db123ed8d051d095007491c9184b6ce
            Log:
            JENKINS-24673 Noting merge of #1530.

            Compare: https://github.com/jenkinsci/jenkins/compare/1dd60ec77808...416bdef94db1

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/jenkins/tasks/SimpleBuildWrapper.java test/src/test/java/jenkins/tasks/SimpleBuildWrapperTest.java http://jenkins-ci.org/commit/jenkins/416bdef94db123ed8d051d095007491c9184b6ce Log: JENKINS-24673 Noting merge of #1530. Compare: https://github.com/jenkinsci/jenkins/compare/1dd60ec77808...416bdef94db1
            Hide
            jglick Jesse Glick added a comment -

            Core change merged towards 1.599.

            Show
            jglick Jesse Glick added a comment - Core change merged towards 1.599.
            Hide
            hanabishi Marcus Jacobsson added a comment -

            Was looking a bit more on this now that I got some free time again, the only thing we need right now is to be able to create a wrapper for the listener output. So we can filter the output and color code the output. For example we have a plugin that formats or output simular to https://wiki.jenkins-ci.org/display/JENKINS/Timestamper and https://wiki.jenkins-ci.org/display/JENKINS/AnsiColor+Plugin as well as a plugin to filer out passwords from the console.

            Show
            hanabishi Marcus Jacobsson added a comment - Was looking a bit more on this now that I got some free time again, the only thing we need right now is to be able to create a wrapper for the listener output. So we can filter the output and color code the output. For example we have a plugin that formats or output simular to https://wiki.jenkins-ci.org/display/JENKINS/Timestamper and https://wiki.jenkins-ci.org/display/JENKINS/AnsiColor+Plugin as well as a plugin to filer out passwords from the console.
            Hide
            jglick Jesse Glick added a comment -
            Show
            jglick Jesse Glick added a comment - Marcus Jacobsson see JENKINS-27392 .
            Hide
            jglick Jesse Glick added a comment -

            Workflow 1.8 has the new wrap step.

            Show
            jglick Jesse Glick added a comment - Workflow 1.8 has the new wrap step.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                hanabishi Marcus Jacobsson
              • Votes:
                3 Vote for this issue
                Watchers:
                9 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: