Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26755

hudson.model.Computer#getEnvironment should be cached

    Details

    • Similar Issues:

      Description

      a node environment is set as the slave channel is established. The resulting EnvVar doesn't need to be computed again and again any time hudson.model.Computer#getEnvironment is called. This has a bad side effect when a plugin involved in build queue need to check node environment to determine if ti can host the build : relying on remoting IO within a syncrhonized block can just block the queue processing.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            core/src/main/java/hudson/model/Computer.java
            http://jenkins-ci.org/commit/jenkins/e0a394ab8666163a6256cceb20a79afb297c564d
            Log:
            JENKINS-26755 cache node environment
            to prevent inefficient channel overuse

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: core/src/main/java/hudson/model/Computer.java http://jenkins-ci.org/commit/jenkins/e0a394ab8666163a6256cceb20a79afb297c564d Log: JENKINS-26755 cache node environment to prevent inefficient channel overuse
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De loof
            Path:
            core/src/main/java/hudson/model/Computer.java
            http://jenkins-ci.org/commit/jenkins/7f15e67fc72540e0eca7c0163dce5a7f641d10fe
            Log:
            Merge pull request #1559 from ndeloof/JENKINS-26755

            JENKINS-26755 cache node environment

            Compare: https://github.com/jenkinsci/jenkins/compare/1e7713402bf3...7f15e67fc725

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: core/src/main/java/hudson/model/Computer.java http://jenkins-ci.org/commit/jenkins/7f15e67fc72540e0eca7c0163dce5a7f641d10fe Log: Merge pull request #1559 from ndeloof/ JENKINS-26755 JENKINS-26755 cache node environment Compare: https://github.com/jenkinsci/jenkins/compare/1e7713402bf3...7f15e67fc725
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Nicolas De Loof
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/70abf12328e2e92de2de19b65bd08467b016a80e
            Log:
            [FIXED JENKINS-26755] document fixed issue

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: changelog.html http://jenkins-ci.org/commit/jenkins/70abf12328e2e92de2de19b65bd08467b016a80e Log: [FIXED JENKINS-26755] document fixed issue
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3964
            JENKINS-26755 cache node environment (Revision e0a394ab8666163a6256cceb20a79afb297c564d)
            [FIXED JENKINS-26755] document fixed issue (Revision 70abf12328e2e92de2de19b65bd08467b016a80e)

            Result = SUCCESS
            nicolas de loof : e0a394ab8666163a6256cceb20a79afb297c564d
            Files :

            • core/src/main/java/hudson/model/Computer.java

            nicolas de loof : 70abf12328e2e92de2de19b65bd08467b016a80e
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3964 JENKINS-26755 cache node environment (Revision e0a394ab8666163a6256cceb20a79afb297c564d) [FIXED JENKINS-26755] document fixed issue (Revision 70abf12328e2e92de2de19b65bd08467b016a80e) Result = SUCCESS nicolas de loof : e0a394ab8666163a6256cceb20a79afb297c564d Files : core/src/main/java/hudson/model/Computer.java nicolas de loof : 70abf12328e2e92de2de19b65bd08467b016a80e Files : changelog.html

              People

              • Assignee:
                Unassigned
                Reporter:
                ndeloof Nicolas De Loof
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: