Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-34854

Some properties missed in the introduction in SystemProperties

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      During implementation of JENKINS-34755 the author only searched for System.getProperty and missed lines like Boolean.getBoolean and Integer.getInteger()

      Example here: https://github.com/jenkinsci/jenkins/blob/99f80a0b0b93a6d7c928d21849d96e0d642e5d1f/core/src/main/java/hudson/model/ParametersAction.java#L270

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            As an author, I agree that update of JENKINS-34755 to ALL properties was incomplete. Since it involves security fixes, I consider it as a major bug.

            Show
            oleg_nenashev Oleg Nenashev added a comment - As an author, I agree that update of JENKINS-34755 to ALL properties was incomplete. Since it involves security fixes, I consider it as a major bug.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/ProxyConfiguration.java
            core/src/main/java/hudson/Util.java
            core/src/main/java/hudson/model/AsyncAperiodicWork.java
            core/src/main/java/hudson/model/AsyncPeriodicWork.java
            core/src/main/java/hudson/model/DownloadService.java
            core/src/main/java/hudson/model/ParametersAction.java
            core/src/main/java/hudson/model/UpdateCenter.java
            core/src/main/java/hudson/slaves/CloudSlaveRetentionStrategy.java
            core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java
            core/src/main/java/hudson/triggers/SCMTrigger.java
            core/src/main/java/jenkins/install/InstallUtil.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol3.java
            core/src/main/java/jenkins/util/ProgressiveRendering.java
            core/src/main/java/jenkins/util/SystemProperties.java
            http://jenkins-ci.org/commit/jenkins/1d2b15173c48c3a78d6b96d99f6e045f43ff07bc
            Log:
            JENKINS-34854 - Migrate missing settings to SystemProperties (#2362)

            • JENKINS-34854 - Migrate missing Integer and Boolean properties to SystemProperties
            • JENKINS-34854 - Some fixes in Long methods Javadoc and log messages
            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/ProxyConfiguration.java core/src/main/java/hudson/Util.java core/src/main/java/hudson/model/AsyncAperiodicWork.java core/src/main/java/hudson/model/AsyncPeriodicWork.java core/src/main/java/hudson/model/DownloadService.java core/src/main/java/hudson/model/ParametersAction.java core/src/main/java/hudson/model/UpdateCenter.java core/src/main/java/hudson/slaves/CloudSlaveRetentionStrategy.java core/src/main/java/hudson/slaves/ConnectionActivityMonitor.java core/src/main/java/hudson/triggers/SCMTrigger.java core/src/main/java/jenkins/install/InstallUtil.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol3.java core/src/main/java/jenkins/util/ProgressiveRendering.java core/src/main/java/jenkins/util/SystemProperties.java http://jenkins-ci.org/commit/jenkins/1d2b15173c48c3a78d6b96d99f6e045f43ff07bc Log: JENKINS-34854 - Migrate missing settings to SystemProperties (#2362) JENKINS-34854 - Migrate missing Integer and Boolean properties to SystemProperties JENKINS-34854 - API methods for Long variables JENKINS-34854 - Migrate Long settings to SystemProperties JENKINS-34854 - Leftover change (I should use Save All) JENKINS-34854 - Some fixes in Long methods Javadoc and log messages
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            released in 2.6

            Show
            oleg_nenashev Oleg Nenashev added a comment - released in 2.6

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                rsandell rsandell
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: