Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38309

Make ForkScanner return Parallel Branches in same order as others

    Details

    • Similar Issues:

      Description

      When using the ForkScanner to walk through a flow graph, most things are returned in logical reverse order (end --> start, right), but parallels are done in the opposite (first branch, then second).

      The API doesn't guarantee parallel ordering but it is helpful for consumers to have the same guarantee in place for parallels too, since it turns out to be practical.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScanner.java
            src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java
            src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java
            http://jenkins-ci.org/commit/workflow-api-plugin/dcd2152870040fe8dd1ee4fa616542b6bb3329dc
            Log:
            Ensure that parallels in ForkScanner follow the same reverse-order iteration, per JENKINS-38309

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScanner.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/FlowScannerTest.java src/test/java/org/jenkinsci/plugins/workflow/graphanalysis/ForkScannerTest.java http://jenkins-ci.org/commit/workflow-api-plugin/dcd2152870040fe8dd1ee4fa616542b6bb3329dc Log: Ensure that parallels in ForkScanner follow the same reverse-order iteration, per JENKINS-38309
            Hide
            svanoort Sam Van Oort added a comment -

            Merged, going into next release.

            Show
            svanoort Sam Van Oort added a comment - Merged, going into next release.
            Hide
            svanoort Sam Van Oort added a comment -

            Released as v2.4

            Show
            svanoort Sam Van Oort added a comment - Released as v2.4

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                svanoort Sam Van Oort
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: