Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38457

FlowGraphTable shows parallel branches out of order

    Details

    • Similar Issues:

      Description

      This surprising behavior, plus the fact that DepthFirstScanner goes in reverse branch order as opposed to FlowGraphWalker which (AFAIK) went in forward order, means that ParallelStepTest.suspend breaks: rather than seeing branches as A/B/C you see them as A/C/B.

      Probably regressed by workflow-support PR 9.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/4798a812cd7e749c2e272d2b9bbbdb5fc3a793f3
            Log:
            JENKINS-38457 Temporarily suppressing part of test which shows the regression.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/4798a812cd7e749c2e272d2b9bbbdb5fc3a793f3 Log: JENKINS-38457 Temporarily suppressing part of test which shows the regression.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/0ca8da72d9de73ccfdc58013f12bbee843c76108
            Log:
            Revert "JENKINS-38457 Temporarily suppressing part of test which shows the regression."

            This reverts commit 4798a812cd7e749c2e272d2b9bbbdb5fc3a793f3.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/test/java/org/jenkinsci/plugins/workflow/cps/steps/ParallelStepTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/0ca8da72d9de73ccfdc58013f12bbee843c76108 Log: Revert " JENKINS-38457 Temporarily suppressing part of test which shows the regression." This reverts commit 4798a812cd7e749c2e272d2b9bbbdb5fc3a793f3.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Sam Van Oort
            Path:
            src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/FlowGraphTable.java
            http://jenkins-ci.org/commit/workflow-support-plugin/e0676fad9646031d05bd0dba0244cc6d00d4d106
            Log:
            Revert "[FIXED JENKINS-38457] Go back to FlowGraphWalker for now."

            This reverts commit a61d54906f970854ae8ea52019282e5c91bb5ef1.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sam Van Oort Path: src/main/java/org/jenkinsci/plugins/workflow/support/visualization/table/FlowGraphTable.java http://jenkins-ci.org/commit/workflow-support-plugin/e0676fad9646031d05bd0dba0244cc6d00d4d106 Log: Revert " [FIXED JENKINS-38457] Go back to FlowGraphWalker for now." This reverts commit a61d54906f970854ae8ea52019282e5c91bb5ef1.
            Hide
            jglick Jesse Glick added a comment -

            IIUC this is now fixed.

            Show
            jglick Jesse Glick added a comment - IIUC this is now fixed.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            http://jenkins-ci.org/commit/workflow-cps-plugin/43db33d447ede6090cd80decd307419d85fc0f7b
            Log:
            Pick up JENKINS-38457 fix.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml http://jenkins-ci.org/commit/workflow-cps-plugin/43db33d447ede6090cd80decd307419d85fc0f7b Log: Pick up JENKINS-38457 fix.

              People

              • Assignee:
                svanoort Sam Van Oort
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: