Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48818

Git plugin no longer updates submodules with spaces in the name

    Details

    • Similar Issues:

      Description

      If a submodule has a space in its name then Jenkins will fail to update that submodule. It looks like the reason is that the regex search has changed from:

      git config -f .gitmodules --get-regexp ^submodule\.(.*)\.url

      to:

      git config -f .gitmodules --get-regexp ^submodule\.([^ ].*)\.url

      This now ignores a submodule with a name something like:

      Stingray/Stingray Studio 12.2

        Attachments

          Issue Links

            Activity

            Hide
            markewaite Mark Waite added a comment - - edited

            Thanks to both of you. I need a code review of the pull request, then I can release a new version. Francis Labrie, since you suggested the regular expression change, would you be willing to review the change?

            Show
            markewaite Mark Waite added a comment - - edited Thanks to both of you. I need a code review of the pull request , then I can release a new version. Francis Labrie , since you suggested the regular expression change, would you be willing to review the change?
            Hide
            flabrie Francis Labrie added a comment -

            Done

            Show
            flabrie Francis Labrie added a comment - Done
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            src/test/java/org/jenkinsci/plugins/gitclient/GitClientTest.java
            src/test/java/org/jenkinsci/plugins/gitclient/SubmodulePatternStringTest.java
            http://jenkins-ci.org/commit/git-client-plugin/69297552b3c36e084bea336448c6ad82763b303a
            Log:
            Fix both JENKINS-48818 and JENKINS-46054

            Add JENKINS-48818 test - space character in submodule remote name

            Submodule remote name which contains a space character was supported by
            git client plugin versions prior to 2.7.0. The bug fix for JENKINS-46054
            (support submodule update when the remote name or the remote URL end with
            '.url') broke support for submodule remote names which contain a space.

            This includes a test to show that a remote name containing a space
            character is not correctly handled by the 2.7.0 change.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java src/test/java/org/jenkinsci/plugins/gitclient/GitClientTest.java src/test/java/org/jenkinsci/plugins/gitclient/SubmodulePatternStringTest.java http://jenkins-ci.org/commit/git-client-plugin/69297552b3c36e084bea336448c6ad82763b303a Log: Fix both JENKINS-48818 and JENKINS-46054 Add JENKINS-48818 test - space character in submodule remote name Submodule remote name which contains a space character was supported by git client plugin versions prior to 2.7.0. The bug fix for JENKINS-46054 (support submodule update when the remote name or the remote URL end with '.url') broke support for submodule remote names which contain a space. This includes a test to show that a remote name containing a space character is not correctly handled by the 2.7.0 change.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            src/test/java/org/jenkinsci/plugins/gitclient/SubmodulePatternStringTest.java
            http://jenkins-ci.org/commit/git-client-plugin/2dcbb2d62a980468d339e52f4f8dd6653473d5cd
            Log:
            Merge pull request #296 from MarkEWaite/explore-JENKINS-46054

            Fix JENKINS-48818 and keep JENKINS-46054 fixed

            Compare: https://github.com/jenkinsci/git-client-plugin/compare/21914aaf97f0...2dcbb2d62a98

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java src/test/java/org/jenkinsci/plugins/gitclient/SubmodulePatternStringTest.java http://jenkins-ci.org/commit/git-client-plugin/2dcbb2d62a980468d339e52f4f8dd6653473d5cd Log: Merge pull request #296 from MarkEWaite/explore- JENKINS-46054 Fix JENKINS-48818 and keep JENKINS-46054 fixed Compare: https://github.com/jenkinsci/git-client-plugin/compare/21914aaf97f0...2dcbb2d62a98
            Hide
            markewaite Mark Waite added a comment -

            Fixed in git client plugin 2.7.1

            Show
            markewaite Mark Waite added a comment - Fixed in git client plugin 2.7.1

              People

              • Assignee:
                markewaite Mark Waite
                Reporter:
                stevebaxter Steve Baxter
              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: