Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-55582

Convert modules to plugins

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      None of the currently bundled jenkins-module packages actually look like they need to be modules: they do not appear to need to be loaded in the same class loader as jenkins-core.jar, nor to have extensions/services registered early in the startup sequence. As such, they could be made into regular plugins (hpi packaging), and the usual split-plugins.txt registry used to retain compatibility for existing plugins which happen to refer to their classes (InstanceIdentity and SshCommandFactory are the main examples).

      As an aside refiled as JENKINS-57023.

        Attachments

          Issue Links

            Activity

            Hide
            jglick Jesse Glick added a comment -

            Started off by making sure they all at least have up-to-date build metadata, which should make things easier.

            Show
            jglick Jesse Glick added a comment - Started off by making sure they all at least have up-to-date build metadata, which should make things easier.
            Hide
            jglick Jesse Glick added a comment -

            JENKINS-44100 would be useful here too.

            Show
            jglick Jesse Glick added a comment - JENKINS-44100 would be useful here too.
            Hide
            danielbeck Daniel Beck added a comment -

            Why though?

            Show
            danielbeck Daniel Beck added a comment - Why though?
            Hide
            jglick Jesse Glick added a comment -

            The JNLP 4 protocol implementation does not work unless instance-identity (or technically some InstanceIdentityProvider) is installed, so it would be cleaner to move that to a plugin as well and express a dependency.

            Show
            jglick Jesse Glick added a comment - The JNLP 4 protocol implementation does not work unless instance-identity (or technically some InstanceIdentityProvider ) is installed, so it would be cleaner to move that to a plugin as well and express a dependency.
            Hide
            danielbeck Daniel Beck added a comment -

            Or, alternatively, do none of this…?

            Show
            danielbeck Daniel Beck added a comment - Or, alternatively, do none of this…?
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            I think it needs a JEP. I am in favor of killing the "module" type and converting everything to plugins, but this is a massive change which requires careful review and public discussion

            Show
            oleg_nenashev Oleg Nenashev added a comment - I think it needs a JEP. I am in favor of killing the "module" type and converting everything to plugins, but this is a massive change which requires careful review and public discussion
            Hide
            jglick Jesse Glick added a comment -

            It is actually not a large change at all; turned out to be quite straightforward. See the core PR for summary.

            Show
            jglick Jesse Glick added a comment - It is actually not a large change at all; turned out to be quite straightforward. See the core PR for summary.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: