Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-63301

Slave to Agent Renaming: MasterToSlaveCallable

    Details

    • Similar Issues:

      Description

      "Slave" has been deprecated in favor of "agent" since Jenkins 2.

      This is outside my area of expertise, but the Git plugin (possibly others) extend the class core/src/main/java/jenkins/security/MasterToSlaveCallable.java

      This means it would be pointless to rename the extending classes until this is renamed in core.

      What are the compatibility issues, and has there been discussion on them? What it would it take: some coordinated effort on each affected plugin?

       

      For a real world workflow where someone contributes to FOSS projects and encounters this:

      1. I reviewed a pull request on a FOSS project, and saw a Jenkins job was failing
      2. Viewed console output to identify the issue (here, a benign one, the author likely force-pushed while the job was running), and read this:
      3. Caused: hudson.plugins.git.GitException: Could not checkout 1e45d6cd7e5d6b076293b442a9ad14bcb3ba3f94
        at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2777)
        at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:161)
        at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$GitCommandMasterToSlaveCallable.call(RemoteGitImpl.java:154)

        Attachments

          Activity

          Hide
          markewaite Mark Waite added a comment -

          Thanks for reporting the issue. Yes, it will take a significant effort to update the API names to not use offensive terminology in the API names.

          The Jenkins project has chosen to replace the offensive terminology through a series of steps. The replacement of "slave" with "agent" started in 2016 and has been focused on replacement in the user interface components.

          The next step is to select the replacement term for the word "master" and replace it in the user interface components and the documentation.

          A later step will be to rework the API names. However, API name rework will require a significant technical investment so that we do not break the many years of successful compatibility that we have maintained.

          Show
          markewaite Mark Waite added a comment - Thanks for reporting the issue. Yes, it will take a significant effort to update the API names to not use offensive terminology in the API names. The Jenkins project has chosen to replace the offensive terminology through a series of steps. The replacement of "slave" with "agent" started in 2016 and has been focused on replacement in the user interface components. The next step is to select the replacement term for the word "master" and replace it in the user interface components and the documentation. A later step will be to rework the API names. However, API name rework will require a significant technical investment so that we do not break the many years of successful compatibility that we have maintained.

            People

            • Assignee:
              Unassigned
              Reporter:
              jacobtylerwalls Jacob Walls
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: