Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9016

Git creates usernames based on 'name' not the email.

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      I realize mapping git author/commit users back to Jenkin's users is pain, but perhaps it could be done a little better.

      Some ideas:

      • Try looking up a user's email and comparing that.
      • Using the user portion from the email (e.g. someuser@example.com becomes someuser).
      • Looking up the user's email in LDAP, if LDAP is being used.

      The last would be ideal for us.

      Ciao!

        Attachments

          Issue Links

            Activity

            Hide
            dageissl Daniel Geißler added a comment - - edited

            Jose Camacho we have a very similar setup in my company. We also see that multiple users with the same email are created (one from AD when the user loges in, the other from git plugin).

            What we found was that having the git authors name matching the AD displayName seems to associate the users correctly (that can be seen in the projects changes too). If i remember correctly, when you are using Bitbucket with AD, you can enforce that name matching in all commits.

            Still a matching based on the email adress would be so much more convenient.

             

            EDIT: rechecked the association and it seems to work only in special cases, that i have to investigate further, as of today we are stuck to the system property to allow everything too.

            Show
            dageissl Daniel Geißler added a comment - - edited Jose Camacho we have a very similar setup in my company. We also see that multiple users with the same email are created (one from AD when the user loges in, the other from git plugin). What we found was that having the git authors name matching the AD displayName seems to associate the users correctly (that can be seen in the projects changes too). If i remember correctly, when you are using Bitbucket with AD, you can enforce that name matching in all commits. Still a matching based on the email adress would be so much more convenient.   EDIT: rechecked the association and it seems to work only in special cases, that i have to investigate further, as of today we are stuck to the system property to allow everything too.
            Hide
            swf Yves Schumann added a comment -

            We struggle on this issue too and in my opinion this ist not a minor issue, it's more an incident! Actually the issue is some kind of a show stopper as the user did not receive proper notifications anymore.

            Show
            swf Yves Schumann added a comment - We struggle on this issue too and in my opinion this ist not a minor issue, it's more an incident ! Actually the issue is some kind of a show stopper as the user did not receive proper notifications anymore.
            Hide
            lemairea Antoine Le Maire added a comment -

            We also struggle on this issue, any progress ?

            Show
            lemairea Antoine Le Maire added a comment - We also struggle on this issue, any progress ?
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: George
            Path:
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
            src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java
            src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy
            src/main/webapp/help/globalConfig/allowUnregistered.html
            http://jenkins-ci.org/commit/email-ext-plugin/19081b2aa3d32c479125b538c545fdd3065960f8
            Log:
            JENKINS-43268 adding global checkbox to allow sending to unregistered emails. This is a workaround to a SCM plugin issue, like JENKINS-9016 and probably others (#161)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: George Path: src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java src/main/resources/hudson/plugins/emailext/ExtendedEmailPublisher/global.groovy src/main/webapp/help/globalConfig/allowUnregistered.html http://jenkins-ci.org/commit/email-ext-plugin/19081b2aa3d32c479125b538c545fdd3065960f8 Log: JENKINS-43268 adding global checkbox to allow sending to unregistered emails. This is a workaround to a SCM plugin issue, like JENKINS-9016 and probably others (#161)
            Hide
            patrickv Patrick Van Brussel added a comment -

            Would it be possible to have some kind of 'domain filter' when you enable the 'Allow sending to unregistered users' checkbox?

            For instance: allow sending mails to contributers to a git repo that don't have a Jenkins account, but that do have an email address set up that ends with '@domain.com'.

            This would be interesting so that when we're using open source git(hub) repositories we don't accidentally sent out mails to the contributers there, when one of our builds fail.

            Show
            patrickv Patrick Van Brussel added a comment - Would it be possible to have some kind of 'domain filter' when you enable the 'Allow sending to unregistered users' checkbox? For instance: allow sending mails to contributers to a git repo that don't have a Jenkins account, but that do have an email address set up that ends with '@domain.com'. This would be interesting so that when we're using open source git(hub) repositories we don't accidentally sent out mails to the contributers there, when one of our builds fail.

              People

              • Assignee:
                ndeloof Nicolas De Loof
                Reporter:
                docwhat Christian Höltje
              • Votes:
                31 Vote for this issue
                Watchers:
                39 Start watching this issue

                Dates

                • Created:
                  Updated: