Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-18435

Navigating back, then forward, from a job configuration causes loss of config data

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Chrome version 27.0.1453.116 on MacOS 10.6.8.
    • Similar Issues:

      Description

      1. Open a job configuration that has a conditional build step defined in it, with the Chrome browser (Firefox does not show this problem).
      2. Click the back button to navigate away from the config.
      3. Click forward to go back to the config.
      4. The conditional build step settings will be blank/default, but all other job configuration remains correct.

      This is a really nasty bug, I've had a number of users accidentally break their configs without realizing it, because if you save after this happens you lose the conditional build step settings. Luckily the Job Config History plugin makes it easy for us to undo this.

        Attachments

          Issue Links

            Activity

            owenmehegan Owen Mehegan created issue -
            Hide
            domi Dominik Bartholdi added a comment -

            sorry, I have currently whats causing it...

            Show
            domi Dominik Bartholdi added a comment - sorry, I have currently whats causing it...
            Hide
            owenmehegan Owen Mehegan added a comment -

            Dominik - checking on your comment, do you know what the problem is?

            Show
            owenmehegan Owen Mehegan added a comment - Dominik - checking on your comment, do you know what the problem is?
            Hide
            domi Dominik Bartholdi added a comment -

            No, sorry...

            Show
            domi Dominik Bartholdi added a comment - No, sorry...
            Hide
            ryan Ryan Hass added a comment - - edited

            It should be noted that this affects global jenkins configurations and will flip bits for boolean values which should be set to true, to false. This also happens on portions of the configuration page which are not rendered, and need to be expanded to see their values. This is a very critical issue.

            My Chrome version is: Version 35.0.1916.114

            Linux x86-64

            Show
            ryan Ryan Hass added a comment - - edited It should be noted that this affects global jenkins configurations and will flip bits for boolean values which should be set to true, to false. This also happens on portions of the configuration page which are not rendered, and need to be expanded to see their values. This is a very critical issue. My Chrome version is: Version 35.0.1916.114 Linux x86-64
            ryan Ryan Hass made changes -
            Field Original Value New Value
            Component/s core [ 15593 ]
            Hide
            danielbeck Daniel Beck added a comment -

            Could be related to this: https://rm.cloudbees.com/issues/1959

            Show
            danielbeck Daniel Beck added a comment - Could be related to this: https://rm.cloudbees.com/issues/1959
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-6588 [ JENKINS-6588 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-9564 [ JENKINS-9564 ]
            Hide
            domi Dominik Bartholdi added a comment -

            removing conditional-buildstep, although it happens also with this plugin, it has nothing to do with it but is an issue with jenkins in general

            Show
            domi Dominik Bartholdi added a comment - removing conditional-buildstep, although it happens also with this plugin, it has nothing to do with it but is an issue with jenkins in general
            domi Dominik Bartholdi made changes -
            Component/s conditional-buildstep [ 15947 ]
            domi Dominik Bartholdi made changes -
            Assignee Dominik Bartholdi [ domi ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-17232 [ JENKINS-17232 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-20038 [ JENKINS-20038 ]
            Hide
            danielbeck Daniel Beck added a comment -

            Similar issues affect multiple browsers, so removing Chrome from title.

            Given the number of issues that appear to be duplicates, raising priority.

            Show
            danielbeck Daniel Beck added a comment - Similar issues affect multiple browsers, so removing Chrome from title. Given the number of issues that appear to be duplicates, raising priority.
            danielbeck Daniel Beck made changes -
            Summary Navigating back, then forward, from a job configuration causes loss of config data in Chrome Navigating back, then forward, from a job configuration causes loss of config data
            Priority Major [ 3 ] Critical [ 2 ]
            Hide
            jglick Jesse Glick added a comment -

            Lazy-loaded form fragments are added to the DOM by some JavaScript hooks. Probably these are being run on initial page load but not when revisiting a page, and the browser is throwing out the modified DOM.

            Show
            jglick Jesse Glick added a comment - Lazy-loaded form fragments are added to the DOM by some JavaScript hooks. Probably these are being run on initial page load but not when revisiting a page, and the browser is throwing out the modified DOM.
            Hide
            jglick Jesse Glick added a comment -

            I suspect the most appropriate fix is just to add some JS to block the back/forward buttons while on such a page.

            Show
            jglick Jesse Glick added a comment - I suspect the most appropriate fix is just to add some JS to block the back/forward buttons while on such a page.
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-18679 [ JENKINS-18679 ]
            danielbeck Daniel Beck made changes -
            Labels 2.0
            danielbeck Daniel Beck made changes -
            Labels 2.0 2.0-rejected
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-26062 [ JENKINS-26062 ]
            danielbeck Daniel Beck made changes -
            Link This issue is related to JENKINS-24645 [ JENKINS-24645 ]
            danielbeck Daniel Beck made changes -
            Link This issue is duplicated by JENKINS-21200 [ JENKINS-21200 ]
            recampbell Ryan Campbell made changes -
            Assignee rsandell [ rsandell ]
            Hide
            recampbell Ryan Campbell added a comment -

            rsandell has a PR in review for this issue.

            Show
            recampbell Ryan Campbell added a comment - rsandell has a PR in review for this issue.
            recampbell Ryan Campbell made changes -
            Remote Link This issue links to "Pull Request (Web Link)" [ 14644 ]
            Hide
            danielbeck Daniel Beck added a comment -

            Fixed towards 2.15.

            Show
            danielbeck Daniel Beck added a comment - Fixed towards 2.15.
            danielbeck Daniel Beck made changes -
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 149742 ] JNJira + In-Review [ 193271 ]
            recampbell Ryan Campbell made changes -
            Labels 2.0-rejected 2.0-rejected lts-candidate
            olivergondza Oliver Gond┼ża made changes -
            Labels 2.0-rejected lts-candidate 2.0-rejected
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal OSS-298 (Web Link)" [ 18920 ]

              People

              • Assignee:
                rsandell rsandell
                Reporter:
                owenmehegan Owen Mehegan
              • Votes:
                4 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: